Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ditch ts-loader (for babel) #19

Merged
merged 5 commits into from
Feb 17, 2020
Merged

Ditch ts-loader (for babel) #19

merged 5 commits into from
Feb 17, 2020

Conversation

JakeSidSmith
Copy link
Contributor

In order to simplify our stack, and improve build times (and memory usage), we have decided to try ditching ts-loader, and instead rely on babel for all compilation.

Unfortunately babel is pretty shit, and so we need to specify 2 different loaders; 1 for js, 1 for ts.

Additionally, we've had to include several presets and plugins to allow the full (-ish, there's some things that still don't work - babel is shit) use of typescript features. This, however, also allows us to make use of these features in our js, and will work nicely with the changes that @nikolaevtomov is making to our https://github.com/dabapps/eslint-config-dabapps

isidornygren
isidornygren previously approved these changes Feb 17, 2020
Copy link

@isidornygren isidornygren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Have you tested that const enums are working along with export = / import = whatever that was?

@JakeSidSmith
Copy link
Contributor Author

Const enums are just treated as regular enums, so they should work.

export = / import = I believe is disallowed by our linting config, and even if it isn't... should not be allowed by humans.

@JakeSidSmith
Copy link
Contributor Author

Have created a protected release branch for v0.2.x.
https://github.com/dabapps/create-webpack-config/tree/release-0.2.x

@JakeSidSmith JakeSidSmith merged commit b3af517 into master Feb 17, 2020
@JakeSidSmith JakeSidSmith deleted the ditch-ts-loader branch February 17, 2020 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants