Subroutes #28
Merged
Subroutes #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd prefer the react router syntax, as it's more flexible, and would keep things consistent: https://reacttraining.com/react-router/web/api/Route/component |
lCharlie123l
reviewed
Jan 4, 2018
lCharlie123l
approved these changes
Jan 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to use subroutes to the Collections framework.
The general plan has been to provide helper functions that are backed by the current subgroup system. Paths with <triangle_bracket> items in them can be substituted by using the 'collectionAtSubpath' and 'itemAtSubpath' helpers - further details can be found in the README or the tests files.
I am not 100% sure on the naming of some of the functions - they're a bit verbose. Also, if people would prefer a different matcher rather than triangle brackets, then they should probably say.
Fixes #16