Fix collection count being overwritten by results length when appending results #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AngryLawyer
reviewed
Mar 5, 2018
tests/collections.ts
Outdated
| @@ -291,6 +294,31 @@ describe('Collections', () => { | |||
| expect(results[1].furLength).toBe(10); | |||
| }); | |||
|
|
|||
| it('should default to the results length if no count param is returned from the server onn GET_COLLECTION responses', () => { | |||
AngryLawyer
approved these changes
Mar 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When appending results the
countproperty that is returned from the server was being overwritten by the results length. Thiscountproperty should be the total number of results available from the server rather than the length of the results property