Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix addCollectionItem #47

Merged
merged 3 commits into from
Sep 5, 2019
Merged

Fix addCollectionItem #47

merged 3 commits into from
Sep 5, 2019

Conversation

nvlaarhoven
Copy link
Contributor

Adding an item to a collection was broken.

Problem
It was adding the whole payload (including headers and meta) rather than just the data.

Fix
Fixed by providing action.payload.data instead of action.payload to recordBuilder

@nvlaarhoven
Fix addCollectionItem
63d439d 
recordBuilder needs `action.payload.data` instead of `action.payload`
@nvlaarhoven
Fix test
21fe1f1
@nvlaarhoven
0.4.5
04c2247
@JakeSidSmith JakeSidSmith merged commit 9b49099 into master Sep 5, 2019
@JakeSidSmith JakeSidSmith deleted the fix-add-collections-item branch September 5, 2019 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeSidSmith JakeSidSmith JakeSidSmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nvlaarhoven @JakeSidSmith