This repository has been archived by the owner on Nov 9, 2022. It is now read-only.
Deepclone default value for custom-components #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes 2 edge-cases with custom components and their default value: * If default is falsy (i.e. `''`, `0` or `0.0`) it's replaced with `null`, which may break the custom-component or or violates its prop validation. * If default is non-primitive, a newly created rule of the same ID would receive a mutated, default value form the previous rule.
|
Thanks @rtucek! I'll check this out this weekend. |
dabernathy89
approved these changes
Feb 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes 2 edge-cases with custom components and their default value:
'',0or0.0) it's replaced withnull,which may break the custom-component or violates its prop validation.
receive a mutated, default value form the previous rule.