Let me pass options please! #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dabroek is this project deprecated? |
dabroek
reviewed
Apr 25, 2019
| } | ||
|
|
||
| if (!options) defaultOpts = options; |
There was a problem hiding this comment.
I think you might have wanted to have this assignment turned around. Please also add some brackets while you're add it.
|
Hi @rodrigoimenes! Thanks for your PR. This project is certainly not deprecated, I just haven't had loads of time to look at it, so please be patient with me. |
|
Can you please also add a test for this new functionality? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dont force parse 馃懟