Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker file validation on PRs #519

Closed
dabutvin opened this issue Nov 10, 2019 · 4 comments
Closed

Add Docker file validation on PRs #519

dabutvin opened this issue Nov 10, 2019 · 4 comments

Comments

@dabutvin
Copy link
Contributor

We should use github actions for this. We are building and running tests on appveyor right now on PRs, but this does not include the docker file.

I think eventually we should move everything to github actions, but this would be a good start and give us extra coverage.

I just want to make sure whatever changes are made still let the compression container build so something like this should work

$ docker build -f Dockerfile.CompressImages . -t imgbot
@stale
Copy link

stale bot commented Feb 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the goneStale label Feb 4, 2020
@dabutvin
Copy link
Contributor Author

dabutvin commented Feb 6, 2020

bump

@stale stale bot removed the goneStale label Feb 6, 2020
@stale
Copy link

stale bot commented Apr 7, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the goneStale label Apr 7, 2020
@dabutvin
Copy link
Contributor Author

dabutvin commented Apr 7, 2020

Bump

@stale stale bot removed the goneStale label Apr 7, 2020
dabutvin added a commit that referenced this issue Apr 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants
@dabutvin and others