getBody on null

[buckfuddey]

I found great use of your package however the function getBodyPart() in the file Services/Messages/mail.php line 350 has the option to return null to a function which later calls getBody() on the returned value. And if you call getBody on null it throws a fatal error.

I found that only messages from icloud causes this problem since gmail's own library sets the body (plaintext) in the payload object rather than in a part.

As you can see in the images below, one email object does not have parts, it was recieved from an icloud account and the second from a gmail account, however i have tried with yahoo, hotmail and privately hosted mail servers aswell, and those work.

A suggestion is to do a check first to see if the payload has parts to begin with, and if not extract the data from the payload body itself.

[buckfuddey]

After a few hours spent building my own solution to icloud mails I have found additional issues that you might want to look into considering this is a work in progress. If linebreaks are included in a mail sent from icloud they are split into one part per linebreak. So if I was to write the following.
Hi
My
Name
Is
Buck
That would translate into 5 separate parts that all need to be accounted for if one wants to extract the full email.

Update, the issues seems to stem from sending emails from a phone in combination with icloud, might use different ASCII for linebreak than a computer does.

[JonahKlimack]

can I see the solution you built? I ran into this same problem...

[buckfuddey]

`public function hasNoParts(){
if (empty($this->payload->getParts())) {
return true;
} else {
return false;
}
}

public function extractFromBody(){
if ($this->hasNoParts()) {
$type = $this->payload->getMimeType();
$body = $this->payload->getBody();
if ($type == 'text/html' || $type == 'text/plain') {
$this->bodyArr[$type] = $this->getDecodedBody($body->getData());
}
if ($body->getAttachmentId()) {
$this->attachmentData[] = array(
'id' => $body->getAttachmentId(),
'fileName' => $part->getFilename(),
'mimeType' => $type
);
}
} else {
$parts = $this->payload->getParts();
foreach ($parts as $part) {
if (empty($part->getParts())) {
$type = $part->getMimeType();
$body = $part->getBody();
if ($type == 'text/html' || $type == 'text/plain') {
if (isset($this->messageBodyArr[$type])) {
$this->messageBodyArr[$type] .= $this->getDecodedBody($body->getData());
} else {
$this->messageBodyArr[$type] = $this->getDecodedBody($body->getData());
}
}

				if ($body->getAttachmentId()) {
					$this->attachmentData[] = array(
						'id' => $body->getAttachmentId(),
						'fileName'  => $part->getFilename(),
						'mimeType' => $type
					);						
				}				
			} else {
				$subParts = $part->getParts();
				$this->traverseData($subParts);
			}
		}
	}		
}

public function traverseData($parts){
	foreach ($parts as $part) {			
		if (empty($part->getParts())) {
			$type = $part->getMimeType();
			$body = $part->getBody();
			if ($type == 'text/html' || $type == 'text/plain') {
				if (isset($this->messageBodyArr[$type])) {
					$this->messageBodyArr[$type] .= $this->getDecodedBody($body->getData());
				} else {
					$this->messageBodyArr[$type] = $this->getDecodedBody($body->getData());
				}						
			}

			if ($body->getAttachmentId()) {
				$this->attachmentData[] = array(
						'id' => $body->getAttachmentId(),
						'fileName'  => $part->getFilename(),
						'mimeType' => $type
				);

			}
		} else {
			$subParts = $part->getParts();
			$this->traverseData($subParts);
		}
	}
}

public function getDecodedBody( $content ) {
$content = str_replace( '_', '/', str_replace( '-', '+', $content ) );
return base64_decode( $content );
}
`
All the functions called that aren't present in the supplied code are google API functions.

[buckfuddey]

New to github, don't know why the supplied code spazzes out half way...

[JonahKlimack]

use 3 backtics and end with

[JonahKlimack]

by the way, thank you very much, I really need to get this done tonight, and this was in the way

[buckfuddey]

No worries, there's way to little info on the google API for PHP anyway.

[JonahKlimack]

I mean, thanks. There's no errors, but they're all null

Am I using this right? Call extractfrombody? when looping through messages? Looking over it...

[buckfuddey]

you need to have the payload as a class variable to be able to extract data on it. I set the payload from the message as such:
$message = $this->service->users_messages->get( 'me', $messageId );
$this->payload = $message->getPayload();

[JonahKlimack]

in the constructor of mail.php?

[JonahKlimack]

aha! got it! Thanks!

[buckfuddey]

It's already set in the mail constructor of the dacastro4 mail.php class. As long as you instantiate the class it should work. However, I'm not sure it can be called statically like other methods. The class I made is not the same however, so you might run into issues.

[JonahKlimack]

some small things, but I implemented it and pushed to production, you saved me man, I had a meeting tomorrow and I was going to tell them this part isn't working, thanks.

[buckfuddey]

no worries, you'll do the same for someone else some day :)

[valentim04]

Hi, here is a simple but effective solution:

$gmail = LaravelGmail::message()->preload()->all();

    $messages = [];
    foreach ($gmail as $key) {
             
        if ($key->hasNoParts() == false ){
            $body = $key->getHtmlBody();
        } else {
            $body0 = $key->payload->getBody();
            $body = $key->getDecodedBody($body0->data);
        }

}

[nunomsh]

This solution wont work if the body as "deeper parts", and you wont get attachments if the body is null.
One possible solution is to get the payload and parts

In your controller:

public function decodeBody($body) 
	{
		$rawData = $body;
		$sanitizedData = strtr($rawData,'-_', '+/');
		$decodedMessage = base64_decode($sanitizedData);
		if(!$decodedMessage){
			$decodedMessage = FALSE;
		}
		return $decodedMessage;
	}

In the function you want to get the emails. In my case I want to get all the emails and attachments and store then, but for this example just the general idea

$messages = LaravelGmail::message()->in('INBOX')->unread()->preload()->all()->take(50);

foreach ($messages as $val => $mlist) {

	$body = $messages[$val]->payload->getBody();
	$FOUND_BODY = $this->decodeBody($body['data']);
	$message_id = $mlist->id;
    
	if(!$FOUND_BODY) {
		$parts = $messages[$val]->payload->getParts();
		foreach ($parts  as $part) {
			if($part['body'] && $part['mimeType'] == 'text/html') {
				$FOUND_BODY = $this->decodeBody($part['body']->data);
				break;
			}
		}
	} if(!$FOUND_BODY) {
		foreach ($parts  as $part) {

			if($part['parts'] && !$FOUND_BODY) {
				foreach ($part['parts'] as $p) {
					if($p['mimeType'] === 'text/html' && $p['body']) {
						$FOUND_BODY = $this->decodeBody($p['body']->data);
						break;
					}
				}
			}
			if($FOUND_BODY) {
				break;
			}
		}
	}
  
	
	if ($messages[$val]->hasAttachments()==1) {

		$anexos = $messages[$val]->getAttachments();
		foreach ($anexos as $key => $anexo) {
			$file = $anexos[$key]->getData();
			$fileName= $anexo->filename;
			$anexo->saveAttachmentTo('anexos/', $messages[$val]->getId().'_'.$anexo->getFileName(), 'public');
		}
	}
	
	$assoc = Gmail::updateOrCreate(
		['google_id' =>  $messages[$val]->getId()],
		['name' => $messages[$val]->getFromName(), 
		'subject' => $messages[$val]->getSubject(),
		'body' => $FOUND_BODY,
		'email_date' => $messages[$val]->getDate(),
		'has_attach' =>$messages[$val]->hasAttachments()
	]);
	$assoc->save();
}