Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use name instead of ID in switchOutputWorkflow Action #408

Merged

Conversation

jheimbach
Copy link
Contributor

Q A
Branch? dev-master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets #...

The current implementation with referencing output workflows by ID in the conditional logic action breaks on export/import the form definition.

I fixed this by referencing the output workflow by name instead.

@solverat
Copy link
Member

Hey @jheimbach, thanks for your efforts. I'm not sure if we really should add this to PX. Is it something you need on PX installations, or could we move it to v5 (master branch)?

@jheimbach
Copy link
Contributor Author

Hey @solverat,
we can merge that in v5.

do i have to change the target branch?

@solverat
Copy link
Member

@jheimbach nope, master is good, but you need to resolve the conflicts :(

@jheimbach
Copy link
Contributor Author

@solverat will do.

btw. found out that the condition "outputworkflow" has the same problem, will fix it there also.

@solverat
Copy link
Member

@jheimbach btw, if you have too many issues while rebasing to the latest master - don't hesitate to create new PR instead!

@solverat
Copy link
Member

solverat commented Oct 2, 2023

hey @jheimbach any updates on this?

@solverat solverat force-pushed the fix-switch-outputworkflow-export branch from 3c612c0 to 478d571 Compare October 13, 2023 10:03
@solverat
Copy link
Member

@jheimbach I've just updated your PR:

  • rebase to latest master
  • also check for conditions "outputWorkflow" and change to name relation
  • added a constraint check: if a given output workflow is required by any conditional logic, it is not allowed to change the ow's name, since it heavily depended on that now!

@solverat solverat merged commit 215dbee into dachcom-digital:master Oct 18, 2023
3 checks passed
@solverat
Copy link
Member

Thanks @jheimbach!

@solverat solverat mentioned this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants