Merge pull request #56 from dachcom-digital/fix_55

fix #55
dachcom-digital · Aug 11, 2023 · 4d7a423 · 4d7a423
2 parents 14825bf + a34dce6
commit 4d7a423
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 13 deletions.
diff --git a/.gitignore b/.gitignore
@@ -52,4 +52,4 @@ php-cgi.core
 /tests/_output/*
 /tests/_data/*
 !/tests/_data/.gitkeep
-/tests/_support/_generated/*
+/tests/Support/_generated/*
diff --git a/composer.json b/composer.json
@@ -44,6 +44,6 @@
         "symplify/easy-coding-standard": "^9.0"
     },
     "suggest": {
-        "dachcom-digital/schema": "^2.0"
+        "dachcom-digital/schema": "^3.0"
     }
 }
diff --git a/docs/MetaData/20_Extractors.md b/docs/MetaData/20_Extractors.md
@@ -13,15 +13,15 @@ This method allows you to update the `SeoMetaData` object
 
 ## SeoMetaData Class
 
-| Name | Description
-|------|------------|
-| `setMetaDescription` | Set meta description. |
-| `setTitle` | Set title. |``
-| `setTitle` | Set title. |
-| `addExtraProperty`, `setExtraProperties` | Add a extra property. |
-| `addSchema` | Add a schema block ( `application/ld+json`). **Note!** No script tags are allowed here, only encoded json data! |
-| `addExtraName`, `setExtraNames` | Add a extra name meta field. |
-| `addExtraHttp`, `setExtraHttp` | Add a extra http meta field. |
+| Name                                     | Description                                                                                                     |
+|------------------------------------------|-----------------------------------------------------------------------------------------------------------------|
+| `setMetaDescription`                     | Set meta description.                                                                                           |
+| `setTitle`                               | Set title.                                                                                                      |``
+| `setTitle`                               | Set title.                                                                                                      |
+| `addExtraProperty`, `setExtraProperties` | Add a extra property.                                                                                           |
+| `addSchema`                              | Add a schema block ( `application/ld+json`). **Note!** No script tags are allowed here, only encoded json data! |
+| `addExtraName`, `setExtraNames`          | Add a extra name meta field.                                                                                    |
+| `addExtraHttp`, `setExtraHttp`           | Add a extra http meta field.                                                                                    |
 
 > **Note:** Extractors are prioritized services. 
 > If another extractor supports your element too it could override your current definition.

diff --git a/src/Tool/UrlGenerator.php b/src/Tool/UrlGenerator.php
@@ -70,7 +70,7 @@ protected function generateForAsset(Asset $asset, array $options): ?string
             return null;
         }
 
-        if (!isset($options['thumbnail']) || empty($options['thumbnail'])) {
+        if (empty($options['thumbnail'])) {
             return null;
         }
 
@@ -79,7 +79,7 @@ protected function generateForAsset(Asset $asset, array $options): ?string
             return null;
         }
 
-        $imagePath = $thumbnail->getPath(false);
+        $imagePath = $thumbnail->getPath(['deferredAllowed' => false]);
 
         if (str_contains($imagePath, 'http')) {
             return $imagePath;