remove unused js classes

dachcom-digital · May 24, 2023 · 3d5a9ec · 3d5a9ec
1 parent d8b3d54
commit 3d5a9ec
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 27 deletions.
diff --git a/UPGRADE.md b/UPGRADE.md
@@ -3,6 +3,8 @@
 ## Version 4.1.0
 - [FEATURE] PIMCORE 10.5 support only
 - [IMPROVEMENT] Compatibility with Members 4.1 added
+- [IMPROVEMENT] Remove unused js classes
+- [BUGFIX] [VHS Element] Use right element context in video type selector
 
 ## Version 4.0.10
 - [BUGFIX] fix case sensitivity for accordion in bootstrap3 theme `Resources/views/toolbox/bootstrap3/accordion/partial/Accordion => Resources/views/toolbox/bootstrap3/accordion/partial/accordion`

diff --git a/src/ToolboxBundle/Resources/public/js/backend/toolbox.js b/src/ToolboxBundle/Resources/public/js/backend/toolbox.js
diff --git a/src/ToolboxBundle/Resources/public/js/document/editables/vhs/editor.js b/src/ToolboxBundle/Resources/public/js/document/editables/vhs/editor.js
@@ -93,11 +93,11 @@ pimcore.plugin.toolbox.vhs.editor = Class.create({
                                     }.bind(this),
                                     keyup: function (el) {
                                         if ((el.getValue().indexOf('youtu.be') >= 0 || el.getValue().indexOf('youtube.com') >= 0) && el.getValue().indexOf('http') >= 0) {
-                                            this.up('form').getComponent('type').setValue('youtube');
+                                            el.up('form').getComponent('type').setValue('youtube');
                                         } else if (el.getValue().indexOf('vimeo') >= 0 && el.getValue().indexOf('http') >= 0) {
-                                            this.up('form').getComponent('type').setValue('vimeo');
+                                            el.up('form').getComponent('type').setValue('vimeo');
                                         } else if ((el.getValue().indexOf('dai.ly') >= 0 || el.getValue().indexOf('dailymotion') >= 0) && el.getValue().indexOf('http') >= 0) {
-                                            this.up('form').getComponent('type').setValue('dailymotion');
+                                            el.up('form').getComponent('type').setValue('dailymotion');
                                         }
                                     }.bind(this)
                                 }
@@ -334,7 +334,6 @@ pimcore.plugin.toolbox.vhs.editor = Class.create({
         values['videoParameter'] = videoParameter;
 
         return values;
-
     },
 
     hideWindow: function () {
@@ -344,7 +343,6 @@ pimcore.plugin.toolbox.vhs.editor = Class.create({
         this.form = {};
 
         document.body.classList.remove('toolbox-modal-open');
-
     },
 
     onNodeOver: function (target, dd, e, data) {

diff --git a/src/ToolboxBundle/Resources/public/js/startup.js b/src/ToolboxBundle/Resources/public/js/startup.js
diff --git a/src/ToolboxBundle/ToolboxBundle.php b/src/ToolboxBundle/ToolboxBundle.php
@@ -41,15 +41,13 @@ public function getJsPaths(): array
         return [
             '/admin/toolbox-ckeditor-object-style.js',
             '/bundles/toolbox/js/toolbox-ckeditor-plugins.js',
-            '/bundles/toolbox/js/document/edit.js',
-            '/bundles/toolbox/js/startup.js',
+            '/bundles/toolbox/js/document/edit.js'
         ];
     }
 
     public function getEditmodeJsPaths(): array
     {
         return [
-            '/bundles/toolbox/js/backend/toolbox.js',
             '/bundles/toolbox/js/toolbox-ckeditor-plugins.js',
             '/bundles/toolbox/js/document/editables/areablock.js',
             '/bundles/toolbox/js/document/editables/googlemap.js',