Node 12 compatibility #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It builds on Travis with Node v8, v10 and v12, but fails with older versions. |
|
@dachev any chance you could review this PR, as it is blocking us upgrading to Node 12 |
|
Excellent, thanks a lot. |
|
Thanks @dachev! |
|
I was just testing this, and it doesn't seem like the right code got published. On node 12:
|
|
@holm Thanks for catching this. I pushed 2.5.1 and this time I confirmed that it actually installs. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these changes, I can install the package locally using Node v12.0.0.
I'm no V8 expert, but used the following sources to come up with this patch: