Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0's appearing instead of 9's #9

Closed
brian-leighton opened this issue Sep 3, 2020 · 5 comments
Closed

0's appearing instead of 9's #9

brian-leighton opened this issue Sep 3, 2020 · 5 comments

Comments

@brian-leighton
Copy link

As the title says. When i make a new puzzle using makepuzzle() I recieve 0's in the place of 9's. Anyway to fix this without looping through the array and replacing 0's with 9's?

@dachev
Copy link
Owner

dachev commented Sep 4, 2020

Hi @brianL09 . This sounds like a bug. Unfortunately, I don't have much time to maintain this project these days. I'll do my best to fix it but I can't commit to any timeframe. I hope you understand...

@dachev
Copy link
Owner

dachev commented Sep 4, 2020

Taking a second look, this is not a bug. I agree that it will probably be better to use 1-9 for productivity and readability purposes but that would necessitate internal changes to the entire library. I don't currently have the time for this but I would welcome a PR that comes with a few tests.

@brian-leighton
Copy link
Author

Thanks for the quick response, I appreciate it.
Totally understand not having the time. I'm still relatively new to javascript, but I'll take a look and see what I can figure out. Otherwise, it should be no problem to just switch the 0's in the puzzles to 9's. Thanks again!

@dachev
Copy link
Owner

dachev commented Sep 4, 2020

@brianL09 You have to increment all the values by one.

@brian-leighton
Copy link
Author

Thanks for the advice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants