Remove the use of os.linesep so pyment works on windows. #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The python file I/O routines correctly convert the line separators depending on the OS.
|
Thanks for that job 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The python file I/O routines correctly convert the line separators depending on the OS.
Python uses '\n' as the line separator internally for all OS's. It handles the conversion when you read and write a file in text mode.
I had to make one small change GoogledocTools because it was dropping the last raise clause due to how splitlines() works.
The tests run on linux and windows. I do not have access to an osx machine.
This is essentially an update to #25