Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate positive relative end index for last section in NumpydocTools #60

Closed
wants to merge 2 commits into from
Closed

Conversation

wagnerpeer
Copy link
Contributor

@wagnerpeer wagnerpeer commented Jul 13, 2018

To fix the issue one had to calculate the correct, positive relative end index in NumpydocTools.get_list_key instead of using -1 as end index.

But because there are more issues with already existing numpydoc which gets "converted" to numpydoc I left the test tests/pyment_test_cases.FilesConversionTests.testCaseNoGenDocsAlreadyNumpydoc untouched and I also did not modify the tests/docs_already_numpydoc.py file as this would also obfuscate the current issue with using "Raises" as last section.
However I added a dedicated Python file named tests/issue_49.py and showed my fix working by adding the corresponding unit test in tests/test_issues.py

@wagnerpeer
Copy link
Contributor Author

As this request got not merged yet, I am closing it to clean up my branches and send another request from another branch.

@wagnerpeer wagnerpeer closed this Jul 25, 2018
@dadadel
Copy link
Owner

dadadel commented Jul 25, 2018

@wagnerpeer sorry I didn't yet have a look to this PR.
I've just updated Pyment a new time.
Indeed do not hesitate to send another request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants