fix: ensure media field treats _id as string

dadi · Jun 18, 2019 · 87a1504 · 87a1504
1 parent 463d76a
commit 87a1504
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/dadi/lib/fields/media.js b/dadi/lib/fields/media.js
@@ -23,10 +23,10 @@ module.exports.beforeOutput = function ({
   let normalisedValue = isArraySyntax ? input[field] : [input[field]]
   let mediaObjectIDs = normalisedValue.map(value => {
     if (value && typeof value !== 'string') {
-      return value._id
+      return value._id.toString()
     }
 
-    return value
+    return value ? value.toString() : value
   }).filter(Boolean)
   let composedIDs = []
 
@@ -54,14 +54,16 @@ module.exports.beforeOutput = function ({
         : {}
 
       if (mediaObjects[id]) {
-        let mergedValue = Object.assign({}, mediaObjects[id], value)
+        let mergedValue = Object.assign({}, mediaObjects[id], value, {
+          _id: id
+        })
         let sortedValue = Object.keys(mergedValue).sort().reduce((sortedValue, field) => {
           sortedValue[field] = mergedValue[field]
 
           return sortedValue
         }, {})
 
-        composedIDs.push(id.toString())
+        composedIDs.push(id)
 
         return sortedValue
       }