Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return hook error in afterGet #511

Closed
wants to merge 5 commits into from

Conversation

jimlambie
Copy link
Contributor

@jimlambie jimlambie commented Nov 20, 2018

This PR returns an error to the consumer if an afterGet hook fails:

{ results:
   [ { code: 'API-0002',
       details:
        'notInstalled - API-Error: Cannot find module \'not-a-package\'',
       docLink: 'https://docs.dadi.cloud/api/#api-0002',
       hookName: 'notInstalled',
       title: 'Hook Error' } ],
  metadata: {} }

Close #419

@jimlambie jimlambie changed the title feat: return hook error in afterGet Return hook error in afterGet Nov 20, 2018
@jimlambie jimlambie closed this Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant