Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the various handlers so that they return a buffer instead of a stream. This avoids multiple conversions between buffers and streams throughout the lifecycle of a request. What handlers return is ready to be sent in the response.
As part of this change, we removed reliance on
image-size-stream
to calculate the natural image dimensions, as well as the old method for obtaining EXIF data. We now use sharp for all of this, which should represent a performance improvement.To do before merging:
Closes #390 and #393.