DateTime formatted in list view #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abovedave
commented
Oct 4, 2018
abovedave
changed the title
|
@abovedave is there any info on how to test this? are there options for formatting that need to go into a schema? |
|
|
||
| let dateObj = null | ||
|
|
||
| if (value) { |
There was a problem hiding this comment.
Isn't this if statement redundant? 🤔
| /** | ||
| * The field schema. | ||
| */ | ||
| schema: proptypes.object |
There was a problem hiding this comment.
Sort props alphabetically, please? 😇 🙏
added 2 commits
October 11, 2018 11:24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #448