Fix a few minor datetime bugs #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohmoses
commented
Jul 21, 2019
| @@ -141,26 +141,24 @@ export default class TextInputWithDatePicker extends React.Component { | |||
| const {value} = event.target | |||
| const newDate = new DateTime(event.target.value, format) | |||
|
|
|||
| if (value.length > 0) { | |||
There was a problem hiding this comment.
Make sure you have 'hide whitespace changes' checked, otherwise the diff looks more complicated than it is 🙂
| const parsedDate = | ||
| // Fecha requires a format. If no format is specified, try ISO. | ||
| fecha.parse(date, format || FORMAT_ISO8601) || | ||
| // If format is specified but parsing fails, the value has probably been |
There was a problem hiding this comment.
Suggested change
| // If format is specified but parsing fails, the value has probably been | |
| // If format is specified but parsing fails, the value has probably been |
There was a problem hiding this comment.
Nope, sorry, prettier doesn't like that 😁
eduardoboucas
approved these changes
Jul 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I put a few fixes together into a single PR, because they're tiny.
Bugs fixed:
Also, I fixed an unrelated potential bug in
TextInput(in fortunately otherwise unused code):changed to