Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reload workers on change #34

Merged
merged 1 commit into from May 23, 2019
Merged

Reload workers on change #34

merged 1 commit into from May 23, 2019

Conversation

jimlambie
Copy link
Contributor

This PR introduces a filesystem watcher to reload workers when new js files are added to the workers directory, or existing workers are modified.

In addition, workers are loaded once only to accurately reflect the filesystem structure.

Close #32
Fix #33

@jimlambie jimlambie requested a review from adamkdean May 23, 2019 08:24
@coveralls
Copy link

coveralls commented May 23, 2019 •
edited

Pull Request Test Coverage Report for Build 135

  • 29 of 31 (93.55%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 95.177%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/workers.js 26 28 92.86%
Totals Coverage Status
Change from base Build 133: -0.5%
Covered Lines: 215
Relevant Lines: 220
💛 - Coveralls

adamkdean
adamkdean approved these changes May 23, 2019
View reviewed changes
Copy link
Contributor

@adamkdean adamkdean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — @jimlambie does coveralls run the tests as well?

@jimlambie
Copy link
Contributor Author

@adamkdean Travis runs the tests and sends the coveralls report, to, um, Coveralls

@jimlambie jimlambie merged commit 45d29d8 into master May 23, 2019
@jimlambie jimlambie deleted the feature/hot-reload branch May 23, 2019 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamkdean adamkdean adamkdean approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Worker loader duplicates workers Hot reload worker functions
3 participants
@jimlambie @coveralls @adamkdean