Isolate WorkplaceSearchClient and ElasticsearchClient #1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of making WorkplaceSearchClient extending ElasticsearchClient, we are now making all of them not dependant. So the ElasticsearchClient is not anymore injected into the WorkplaceSearchClient which can run on its own.
Instead of searching globally, which will give most likely wrong numbers if data already exist in the cluster, we could search only within a given custom id.
Let's use longer random custom crawler names as it might conflict if we have a few number of characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of making WorkplaceSearchClient extending ElasticsearchClient, we are now making all of them not dependant. So the ElasticsearchClient is not anymore injected into the WorkplaceSearchClient which can run on its own.