Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix and test data line criteria #22

Merged
merged 1 commit into from
Mar 25, 2019
Merged

Conversation

viniagostini
Copy link
Contributor

Algumas planilhas possuem o campo CPF preenchido com o valor 0, que é avalia como falsy. Assim, nenhuma linha da planilha era reconhecida como dado.

Modifiquei a verificação para olhar apenas para a coluna Nome, já que ela de fato nunca pode assumir nenhum valor falsy.

Passei pelo menos umas 3h hoje pra saber que era isso que estava acontecendo 😅

@viniagostini viniagostini added the bug Something isn't working label Mar 25, 2019
@viniagostini viniagostini self-assigned this Mar 25, 2019
Copy link
Collaborator

@danielfireman danielfireman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch! 😥

@viniagostini viniagostini merged commit 14fe6ea into master Mar 25, 2019
@viniagostini viniagostini deleted the fixDataLineCriteria branch April 28, 2019 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants