Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FTBFS with new GCC 13 #209

Closed
tim77 opened this issue Mar 13, 2023 · 4 comments
Closed

FTBFS with new GCC 13 #209

tim77 opened this issue Mar 13, 2023 · 4 comments

Comments

@tim77
Copy link
Contributor

tim77 commented Mar 13, 2023

Description of Bug

Failed to build from source with new GCC 13.

Attached Log

Additional info

  • OS: Fedora 38+
  • Compiler: GCC 13.0.1

Porting to GCC 13: https://gcc.gnu.org/gcc-13/porting_to.html


The error itself with missing types look like in reshade modules itself. Please tell me if i should report this into reshade bugtracker, not vkBasalt.

@marxin
Copy link

marxin commented Apr 13, 2023

Can be fixed with the following simple patch:

diff --git a/src/reshade/effect_token.hpp b/src/reshade/effect_token.hpp
index e85e2fa..f1b34a8 100644
--- a/src/reshade/effect_token.hpp
+++ b/src/reshade/effect_token.hpp
@@ -7,6 +7,7 @@
 
 #include <string>
 #include <vector>
+#include <cstdint>
 
 namespace reshadefx
 {

Please apply it if possible.

@tim77
Copy link
Contributor Author

tim77 commented Apr 13, 2023

Thanks! New build available for testing.

Ideally we should upstream this fixes to reshade i think?

@parona-source
Copy link

Well seeing that reshade is its own repo then it would be fine to first fix it here and then afterwards look at upstreaming it.

Either way upstream reshade and reshade version included here are not in sync.

Like the gcc-12 issue here was actually fixed two years in advance
d0d37e9
crosire/reshade@bef683b

@ranplayer
Copy link

I've encountered similar errors when trying to build it from AUR (GCC 13.1.1). Full build log:
vkbasalt.tar.gz

An example of error line: ../src/reshade/effect_codegen.hpp:271:66: error: 'const struct reshadefx::struct_info' has no member named 'definition'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants