fix redundant call to Optimizer Cost Function

daelsepara · May 10, 2019 · 536b2dc · 536b2dc
1 parent 782c02c
commit 536b2dc
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/DeepLearnUI/Optimize.cs b/DeepLearnUI/Optimize.cs
@@ -198,8 +198,10 @@ public bool Step(Func<double[], FuncOutput> F, double[] X)
         Add(X, s, z1);
 
         // evaluate cost - and gradient function with new params
-        var f2 = F(X).Error;
-        var df2 = F(X).Gradient;
+        var eval = F(X);
+
+        var f2 = eval.Error;
+        var df2 = eval.Gradient;
 
         Evaluations++;
 
@@ -227,8 +229,6 @@ public bool Step(Func<double[], FuncOutput> F, double[] X)
         var success = false;
         var limit = -1.0;
 
-        FuncOutput eval;
-
         while (true)
         {
             while (((f2 > f1 + z1 * RHO * d1) || (d2 > -SIG * d1)) && (M > 0))
@@ -379,8 +379,7 @@ public bool Step(Func<double[], FuncOutput> F, double[] X)
         }
 
         // if line searched succeeded 
-        if (success)
-        {
+        if (success) {
             f1 = f2;
 
             // Polack-Ribiere direction