Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separation of source types #15

Closed
AndreKkl opened this issue Jun 23, 2016 · 3 comments
Closed

Separation of source types #15

AndreKkl opened this issue Jun 23, 2016 · 3 comments
Projects
Milestone

Comments

@AndreKkl
Copy link

Hey,
some wouldn't say it's an issue but it definitely is: It's easy to see your love to nodejs and javascript but it's an design issue to combine everything in javascript to finally spit it out.
A more welcome separation would at least consider separate css and not a single but bloated javascript file that includes markup, styling and scripting.

I know it's working but it's absolutely unnecessary, makes it harder to customize and does not follow any guideline for separation of different contents. Only because it's possible it doesn't mean that it's a good way.

Please consider in the future a better concept that separates javascript, css and maybe a html-template for the html markup that will be used by your nodejs scripts. It would help to widespread your very cool tool and to gain acceptance.

Best regards

@monbro
Copy link
Contributor

monbro commented Jun 23, 2016

I agree,

independent of the these arguments I think its always good to look how bigger communities and projects are managing their source. https://cdnjs.com/libraries/jqueryui for example also split out the css in their distribution.

Another argument would be the loading priority / performance, so css files are loaded (and might be concatenated) on the top of a html page and the javascript on the bottom.

@frankbaele
Copy link
Contributor

I can agree on the css being included is maybe pushing it a bit to far and I recently stopped doing this.

As for the template, we just wanted to get a new version out and working as fast as possible. We could have used templates that facilitated the later alteration/styling of the application but didn't want to bother with it at that time.

I'm keeping this issue open until both issues (css and html templates) are resolved.

frankbaele added a commit that referenced this issue Jun 24, 2016
@frankbaele frankbaele added 4.x and removed 4.x labels Oct 4, 2016
@frankbaele frankbaele added this to the 4.0.0 milestone Oct 4, 2016
frankbaele added a commit that referenced this issue Oct 4, 2016
@frankbaele
Copy link
Contributor

Hi, we are working on a new version that will have separate css and templates.
The css extraction was the first commit of the new branch templates will be supported by our migration to vue.js .
Feel free to take a look at the new 4.x branch in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3.x
Test
Development

No branches or pull requests

4 participants