fixed duplicate writes

daerup · May 12, 2024 · 285d2df · 285d2df
1 parent 8bd496b
commit 285d2df
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 121 deletions.
diff --git a/Schnacc.Authorization.UnitTests/AuthorizationApiTest.cs b/Schnacc.Authorization.UnitTests/AuthorizationApiTest.cs
diff --git a/Schnacc.Authorization.UnitTests/Schnacc.Authorization.UnitTests.csproj b/Schnacc.Authorization.UnitTests/Schnacc.Authorization.UnitTests.csproj
diff --git a/Schnacc.Database.UnitTests/FirebaseDatabaseTest.cs b/Schnacc.Database.UnitTests/FirebaseDatabaseTest.cs
diff --git a/Schnacc.Database.UnitTests/Schnacc.Database.UnitTests.csproj b/Schnacc.Database.UnitTests/Schnacc.Database.UnitTests.csproj
diff --git a/Schnacc.UserInterface/PlayAreaView/PlayAreaPageView.xaml b/Schnacc.UserInterface/PlayAreaView/PlayAreaPageView.xaml
@@ -56,16 +56,17 @@
             </Grid>
             <Grid DockPanel.Dock="Left">
                 <Grid.RowDefinitions>
-                    <RowDefinition Height="15*"/>
+                    <RowDefinition Height="Auto"/>
                     <RowDefinition Height="80*"/>
-                    <RowDefinition Height="20*"/>
+                    <RowDefinition Height="17*"/>
                 </Grid.RowDefinitions>
                 <Grid Visibility="{Binding Path=ErrorIsVisible, Converter={StaticResource BoolToVisibilityConverter}}">
                     <Grid.RowDefinitions>
                         <RowDefinition Height="40*"/>
                         <RowDefinition Height="40*"/>
                     </Grid.RowDefinitions>
                     <TextBlock 
+                        Margin="0,10"
                         Text="Please Login save your highscore" 
                         Style="{StaticResource InputFontContent}" 
                         TextWrapping="Wrap" 

diff --git a/Schnacc.UserInterface/PlayAreaView/PlayAreaPageViewModel.cs b/Schnacc.UserInterface/PlayAreaView/PlayAreaPageViewModel.cs
@@ -33,9 +33,11 @@ public class PlayAreaViewModel : ViewModelBase, INavigableViewModel
         private DateTime _lastDirectionChange;
         private readonly int _difficultyLevel;
         private int _slowMotionTicks;
+
+        private object writingHighScoreLock = new object();
         private bool _highScoreIsWritten;
 
-        private bool IsAllowedToWriteHighScore => !this._highScoreIsWritten && this.NavigationService.AuthorizationApi.IsAnonymous && this.NavigationService.AuthorizationApi.EmailIsVerified;
+        private bool UserIsAllowedToWriteHighScore => !this.NavigationService.AuthorizationApi.IsAnonymous && this.NavigationService.AuthorizationApi.EmailIsVerified;
         private bool SlowMotionIsActive =>  !this._slowMotionTicks.Equals(0);
         private string SnakeColor => !this.SlowMotionIsActive ? "#3d9e31" : "#6cf85b";
         private string FoodColor => !this.SlowMotionIsActive ? "#f93910" :"#ff33cc";
@@ -207,15 +209,14 @@ private void OnRenderUpdate(object newGameState)
 
         private async Task CheckForGameState()
         {
-            if (this.GameIsOver && this.SessionTokenPresent)
+            if (this.GameIsOver)
             {
-                if (this.IsAllowedToWriteHighScore)
+                if (this.UserIsAllowedToWriteHighScore && !this._highScoreIsWritten)
                 {
+                    this._highScoreIsWritten = true;
                     var newHighScore = new Highscore(this.NavigationService.AuthorizationApi.Username, this.Score);
                     await this._firebaseDatabase.WriteHighScore(newHighScore);
-                    this._highScoreIsWritten = true; 
                 }
-
                 await this._movementTimer.DisposeAsync();
                 await this._renderTimer.DisposeAsync();
             }