Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Add CI test #368

Closed
jschwinger233 opened this issue Dec 18, 2023 · 13 comments · Fixed by #373
Closed

[Enhancement] Add CI test #368

jschwinger233 opened this issue Dec 18, 2023 · 13 comments · Fixed by #373
Labels
automated-issue

Comments

@jschwinger233
Copy link
Member

jschwinger233 commented Dec 18, 2023 •
edited

Improvement Suggestion

My understanding is dae is supposed to run on Linux >= 5.8, let's (let me) add some test via github action against different kernels.

I am proposing to use cilium/little-vm-helper action for running VM inside a github action container.

If maintainers are in favor of this plan, I can draft a PR for review in days.

Potential Benefits

No response
@dae-prow
Copy link
Contributor

dae-prow bot commented Dec 18, 2023

Thanks for opening this issue!

@jschwinger233
Copy link
Member Author

❣️ This issue is marked as wontfix as you have not yet starred this repo. Please kindly consider giving a star to this repo. Your support means a lot to us. Thanks for your understanding. After you become a stargazer, please also reply to this message with the keyword understood. Afterward, I will reopen this issue for you. Once again, your support is much appreciated. Cheers.

understood

@nukeop

This comment has been minimized.

Sign in to view
@daeuniverse daeuniverse deleted a comment from Draky50110 Dec 19, 2023
@Draky50110

This comment has been minimized.

Sign in to view
@daeuniverse daeuniverse deleted a comment from miooochi Dec 19, 2023
@daeuniverse daeuniverse deleted a comment from mzz2017 Dec 19, 2023
jschwinger233 added a commit to jschwinger233/dae that referenced this issue Dec 19, 2023
@jschwinger233
ci: Test against various kernels on PR
be87378 
Closes: daeuniverse#368
@jschwinger233 jschwinger233 mentioned this issue Dec 19, 2023
Merged
jschwinger233 added a commit to jschwinger233/dae that referenced this issue Dec 19, 2023
@jschwinger233
ci: Test against various kernels on PR
9171095 
Closes: daeuniverse#368
jschwinger233 added a commit to jschwinger233/dae that referenced this issue Dec 19, 2023
@jschwinger233
ci: Test against various kernels on PR
ddefc17 
Closes: daeuniverse#368
jschwinger233 added a commit to jschwinger233/dae that referenced this issue Dec 19, 2023
@jschwinger233
ci: Test against various kernels on PR
7f7737a 
Closes: daeuniverse#368
@baglayan

This comment has been minimized.

Sign in to view
@MSDN-WhiteKnight MSDN-WhiteKnight mentioned this issue Dec 19, 2023
Open
@migmit

This comment has been minimized.

Sign in to view
@shafik

This comment has been minimized.

Sign in to view
@Starpelly
Copy link

People are so rude. Don't they know open source developers need those juicy stars to eat?

@wnm210

This comment has been minimized.

Sign in to view
@Daniel-Diaz

This comment has been minimized.

Sign in to view
@dfwinfostudent

This comment has been minimized.

Sign in to view
@daeuniverse daeuniverse locked as off-topic and limited conversation to collaborators Dec 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
automated-issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: Test against various kernels on PR jschwinger233/dae
11 participants
@Daniel-Diaz @Draky50110 @migmit @shafik @jschwinger233 @nukeop @Starpelly @dfwinfostudent @wnm210 @baglayan and others