Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix make with /bin/sh #129

Merged
merged 4 commits into from
Jun 9, 2023
Merged

chore: fix make with /bin/sh #129

merged 4 commits into from
Jun 9, 2023

Conversation

mzz2017
Copy link
Contributor

@mzz2017 mzz2017 commented Jun 9, 2023

Background

https://github.com/daeuniverse/dae/actions/runs/5222582225/jobs/9428252784?pr=128

Checklist

  • The Pull Request has been fully tested

Full changelog

  • Remove bash syntax to support sh.
  • Add Makefile to trigger CI.

Related PR

#126

Copy link
Member

@kunish kunish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mzz2017 mzz2017 merged commit 9c632aa into main Jun 9, 2023
13 checks passed
@mzz2017 mzz2017 deleted the chore_fix_make_via_sh branch June 9, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants