Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix incorrect number of routing rule stringer #131

Merged
merged 1 commit into from
Jun 11, 2023

Conversation

mzz2017
Copy link
Contributor

@mzz2017 mzz2017 commented Jun 10, 2023

Background

Before the fix:

[Jun 10 14:26:46] DEBUG rule: ip([n = 219214]) && l4proto([n = 219215]) -> proxy
[Jun 10 14:26:46] DEBUG         ip() -> <AND>
[Jun 10 14:26:46] DEBUG         l4proto() -> proxy

After the fix:

[Jun 10 14:37:05] DEBUG rule: ip([n = 219214]) && l4proto([n = 1]) -> proxy
[Jun 10 14:37:05] DEBUG         ip() -> <AND>
[Jun 10 14:37:05] DEBUG         l4proto() -> proxy

This problem is caused by the incorrect accumulation of n within the same rule.

This problem only impacts showing.

Checklist

  • The Pull Request has been fully tested

Full changelog

  • Remove accumulation of n.

@mzz2017 mzz2017 changed the title chore: fix incorrect number of rouring rule stringer chore: fix incorrect number of routing rule stringer Jun 10, 2023
@mzz2017 mzz2017 merged commit ff2b025 into main Jun 11, 2023
13 checks passed
@mzz2017 mzz2017 deleted the chore_routingrule_stringer branch June 11, 2023 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants