Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: failed to sniff tls1.2 traffic in some cases #135

Merged
merged 1 commit into from
Jun 11, 2023
Merged

fix: failed to sniff tls1.2 traffic in some cases #135

merged 1 commit into from
Jun 11, 2023

Conversation

mzz2017
Copy link
Contributor

@mzz2017 mzz2017 commented Jun 10, 2023

Background

Tls1.2 traffic with version TLS 1.2 in Handshake Protocol cannot be recognized.

Screenshot_20230611_023827

A traffic sample:

16030300b8010000b403036484b04b0f87a95364166094aa611bb989a6886b4ca4f23480cfd31a1c683e8400002ac02cc02bc030c02f009f009ec024c023c028c027c00ac009c014c013009d009c003d003c0035002f000a010000610000001700150000126f64696e2e67616d652e6461756d2e6e6574000500050100000000000a00080006001d00170018000b00020100000d001a00180804080508060401050102010403050302030202060106030023000000170000ff01000100

Checklist

  • The Pull Request has been fully tested

Full changelog

  • Support both 1.0 and 1.2 in this field.
  • Add a test in tls_test.go.

@mzz2017 mzz2017 merged commit e885e76 into main Jun 11, 2023
13 checks passed
@mzz2017 mzz2017 deleted the fix_tls1.2_sniffing branch June 11, 2023 04:48
@miooochi miooochi mentioned this pull request Jun 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kunish kunish kunish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mzz2017 @kunish