Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should gracefully exit if failed to listen when reloading #138

Merged
merged 1 commit into from
Jun 11, 2023

Conversation

mzz2017
Copy link
Contributor

@mzz2017 mzz2017 commented Jun 11, 2023

Background

Raised from dae-wing. It reloads dae at start, and if at this time dae fails in listen, dae will panic.

Checklist

  • The Pull Request has been fully tested

Full changelog

  • Add a check in the reloading procedure.

@mzz2017 mzz2017 merged commit f494373 into main Jun 11, 2023
13 checks passed
@mzz2017 mzz2017 deleted the fix_listen_exit branch June 11, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants