Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(socks5): udp problem #148

Merged
merged 1 commit into from
Jun 17, 2023
Merged

fix(socks5): udp problem #148

merged 1 commit into from
Jun 17, 2023

Conversation

mzz2017
Copy link
Contributor

@mzz2017 mzz2017 commented Jun 17, 2023 •
edited

Background

Fix up socks5 UDP problem introduced by refactor in #80

Checklist

Full changelog

Issue reference

Related #80.

Affact range

  1. Only Socks5
  2. Only UDP

@miooochi
Copy link
Contributor

Could we include the result (Screenshot) from the unit_test?

@mzz2017
Copy link
Contributor Author

mzz2017 commented Jun 17, 2023

After the fix, we can get the right resolution result.

=== RUN   TestSocks5
    socks_test.go:55: [17.253.144.10]
--- PASS: TestSocks5 (0.45s)
PASS

@mzz2017 mzz2017 merged commit 4fa582e into main Jun 17, 2023
13 checks passed
@mzz2017 mzz2017 deleted the fix_socks5_udp branch June 17, 2023 04:24
MarksonHon pushed a commit to MarksonHon/dae that referenced this pull request Jun 26, 2023
@mzz2017
fix(socks5): udp problem (daeuniverse#148)
ee18786
@miooochi miooochi mentioned this pull request Jun 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miooochi miooochi miooochi approved these changes

Assignees

@mzz2017 mzz2017

Labels
fix priority/high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mzz2017 @miooochi