Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bad connectivity check of dns(tcp) caused by #80 #155

Merged
merged 1 commit into from
Jun 25, 2023

Conversation

mzz2017
Copy link
Contributor

@mzz2017 mzz2017 commented Jun 25, 2023

Background

#80 caused failed connectivity check, which impacts node protocols with bad UDP support like VLESS(XUDP).

In detail, it causes checking only UDP DNS connectivity.

Affected range:

  1. v0.2.0rc1
  2. VLESS protocol

Checklist

Full changelogs

  • Enable correct TCP DNS check.

@miooochi
Copy link
Contributor

Test result from the stakeholder:

image

Copy link
Contributor

@dae-prow dae-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Since the PR has been fully tested, please consider merging it.

@mzz2017 mzz2017 merged commit 5508c37 into main Jun 25, 2023
13 checks passed
@mzz2017 mzz2017 deleted the fix_tcp_dns_check branch June 25, 2023 14:04
MarksonHon pushed a commit to MarksonHon/dae that referenced this pull request Jun 26, 2023
@mzz2017 mzz2017 changed the title fix: bad connectivity check of dns(udp) caused by #80 fix: bad connectivity check of dns(tcp) caused by #80 Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants