Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: expose the routable dialer for dae-wing #172

Merged
merged 1 commit into from
Jul 2, 2023
Merged

Conversation

mzz2017
Copy link
Contributor

@mzz2017 mzz2017 commented Jul 2, 2023

Background

image

To support this feature, we need to expose the routable dialer for dae-wing, so that dae-wing can invoke RouteDialTcp to pull the subscription through dae.

Checklist

@mzz2017 mzz2017 changed the title chore: expose route dialer for dae-wing chore: expose the routable dialer for dae-wing Jul 2, 2023
@miooochi miooochi added the chore label Jul 2, 2023
@mzz2017 mzz2017 added the tested label Jul 2, 2023
Copy link
Contributor

@dae-prow dae-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Since the PR has been fully tested, please consider merging it.

@mzz2017 mzz2017 merged commit 050f9b8 into main Jul 2, 2023
13 checks passed
@mzz2017 mzz2017 deleted the chore_expose_dialer branch July 2, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants