Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(pr-build): use pr.head.sha as default ref #209

Merged
merged 16 commits into from
Jul 13, 2023
Merged

ci(pr-build): use pr.head.sha as default ref #209

merged 16 commits into from
Jul 13, 2023

Conversation

piyoki
Copy link
Contributor

@piyoki piyoki commented Jul 13, 2023

Background

Currently, the version of artifact binaries in pr-build does NOT align with the latest head sha. This PR refactors the seed-build workflow and passes ref as inputs to the build process. In such a way, we may input ref precisely according to different scenarios.

Build (Main) uses ${{ github.ref }}

PR Build (Preview) uses ${{ github.event.pull_request.head.sha }}

Checklist

Full changelogs

  • ci(pr-build): use pr.head.sha instead of github.sha
  • ci(seed-build): add ref as input; default is github.ref
  • ci(pr-build): use ref instead of sha as input
  • ci(seed-build): add pr_build inputs to differentiate type
  • fix: rework commit sha parser
  • ci(seed-build): add pr_number input

Issue reference

NA

Test Result

https://github.com/daeuniverse/dae/actions/runs/5538510193/jobs/10108524157

image image

dae-prow[bot]
dae-prow bot previously approved these changes Jul 13, 2023
Copy link
Contributor

@dae-prow dae-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Since the PR has been fully tested, please consider merging it.

@piyoki piyoki requested a review from MarksonHon July 13, 2023 02:49
Copy link
Contributor

@mzz2017 mzz2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's useful!

@mzz2017 mzz2017 merged commit 39ddd48 into main Jul 13, 2023
16 checks passed
@mzz2017 mzz2017 deleted the pr_build_fix branch July 13, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants