Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(juicity): support certificate pinning #256

Merged
merged 1 commit into from
Aug 4, 2023
Merged

feat(juicity): support certificate pinning #256

merged 1 commit into from
Aug 4, 2023

Conversation

mzz2017
Copy link
Contributor

@mzz2017 mzz2017 commented Aug 3, 2023 •
edited

Background

Sometimes, we want to use a self-signed certificate without trusting it in the system. This PR implements Certificate Pinning to solve it.

See: juicity/juicity#61

Checklist

Full changelogs

  • Support the pinned_certchain_sha256 param of juicity.

Issue reference

N/A

Test Result

@mzz2017 mzz2017 requested a review from a team as a code owner August 3, 2023 15:39
@mzz2017
Copy link
Contributor Author

mzz2017 commented Aug 4, 2023

Test Result:
image

@mzz2017 mzz2017 merged commit 4d61520 into main Aug 4, 2023
22 checks passed
@mzz2017 mzz2017 deleted the feat_pin_cert branch August 4, 2023 10:19
@dae-prow dae-prow bot mentioned this pull request Aug 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kunish kunish kunish approved these changes

Assignees

@mzz2017 mzz2017

Labels
feature not-yet-tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mzz2017 @kunish