Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve docs about pppoe and mark #305

Merged
merged 8 commits into from
Sep 2, 2023
Merged

docs: improve docs about pppoe and mark #305

merged 8 commits into from
Sep 2, 2023

Conversation

mzz2017
Copy link
Contributor

@mzz2017 mzz2017 commented Aug 30, 2023

Background

This PR doesn't really change many codes, but provides a solution for pppoe.

See #304.

Checklist

Full Changelogs

  • Refine ebpf code.
  • Improve docs about pppoe and mark.

Issue Reference

Closes #75

Test Result

@dae-prow dae-prow bot added the documentation Improvements or additions to documentation label Aug 30, 2023
@miooochi
Copy link
Contributor

Will the changes made to the eBPF code implicitly affect non-pppoe users if they ONLY use the LAN interface?

@dae-prow
Copy link
Contributor

dae-prow bot commented Aug 31, 2023

❌ Your branch is currently out-of-sync to main. No worry, I will fix it for you.

@mzz2017
Copy link
Contributor Author

mzz2017 commented Aug 31, 2023

Will the changes made to the eBPF code implicitly affect non-pppoe users if they ONLY use the LAN interface?

No. This PR doesn't introduce new code.

@mzz2017 mzz2017 marked this pull request as draft August 31, 2023 15:04
@mzz2017
Copy link
Contributor Author

mzz2017 commented Aug 31, 2023

I plan to add two hooks to run in dae's lifecycle. This work should be done in the next PR.

@mzz2017 mzz2017 marked this pull request as ready for review August 31, 2023 15:06
@mzz2017
Copy link
Contributor Author

mzz2017 commented Sep 2, 2023

I plan to add two hooks to run in dae's lifecycle. This work should be done in the next PR.

This issue can be done in systemd. Related way is appended in the discussion.

@miooochi
Copy link
Contributor

miooochi commented Sep 2, 2023

Already tested, no abnormal behavior was detected.

@miooochi miooochi added the tested label Sep 2, 2023
Copy link
Contributor

@dae-prow dae-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Since the PR has been fully tested, please consider merging it.

@miooochi miooochi merged commit b9b1624 into main Sep 2, 2023
23 checks passed
@miooochi miooochi deleted the feat_ppp branch September 2, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

关于代理路由器本机的疑问
2 participants