Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add bash completion #352

Merged
merged 2 commits into from
Nov 15, 2023
Merged

chore: add bash completion #352

merged 2 commits into from
Nov 15, 2023

Conversation

shenghuang147
Copy link
Contributor

Background

I am a bash user and I am not used to not having tab completion, so I made this pr

Checklist

Full Changelogs

  • [Implement ...]

Issue Reference

Closes #[issue number]

Test Result

图片

@shenghuang147 shenghuang147 requested a review from a team as a code owner November 4, 2023 15:29
@dae-prow dae-prow bot added the chore label Nov 4, 2023
miooochi
miooochi approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@miooochi miooochi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature, thanks!

@miooochi miooochi added the tested label Nov 6, 2023
dae-prow[bot]
dae-prow bot approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@dae-prow dae-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Since the PR has been fully tested, please consider merging it.

@miooochi miooochi requested a review from mzz2017 November 6, 2023 13:38
@mzz2017 mzz2017 merged commit a829de5 into daeuniverse:main Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miooochi miooochi miooochi approved these changes

@dae-prow dae-prow[bot] dae-prow approved these changes

@mzz2017 mzz2017 Awaiting requested review from mzz2017

Assignees

@shenghuang147 shenghuang147

Labels
chore tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shenghuang147 @miooochi @mzz2017