Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add fish completion #398

Merged
merged 1 commit into from
Jan 2, 2024
Merged

chore: add fish completion #398

merged 1 commit into from
Jan 2, 2024

Conversation

zzzsyyy
Copy link
Contributor

@zzzsyyy zzzsyyy commented Jan 1, 2024 •
edited

Background

Added completions for fish shell

Checklist

Test Result

图片

图片

截图 2024-01-02 00-51-35
截图 2024-01-02 00-51-49

@zzzsyyy zzzsyyy requested a review from a team as a code owner January 1, 2024 16:54
@dae-prow dae-prow bot added the chore label Jan 1, 2024
@zzzsyyy zzzsyyy force-pushed the fish-completion branch 2 times, most recently from fd166ac to ab7f9f8 Compare January 1, 2024 17:00
sumire88
sumire88 previously approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@sumire88 sumire88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Good stuff. Thanks for bringing this to our community. BTW, I am also a fish shell user :)

@sumire88
Copy link
Contributor

sumire88 commented Jan 2, 2024

Is it ready to be merged? @zzzsyyy

@zzzsyyy zzzsyyy requested a review from sumire88 January 2, 2024 04:57
@zzzsyyy
Copy link
Contributor Author

zzzsyyy commented Jan 2, 2024

This time should be ok

sumire88
sumire88 approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@sumire88 sumire88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@sumire88 sumire88 merged commit 9aa9b69 into daeuniverse:main Jan 2, 2024
@dae-prow dae-prow bot mentioned this pull request Jan 2, 2024
Merged
@zzzsyyy zzzsyyy deleted the fish-completion branch January 2, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumire88 sumire88 sumire88 approved these changes

Assignees

@zzzsyyy zzzsyyy

Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zzzsyyy @sumire88