Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(generate-changelogs.yml): generate auth token on the fly #489

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

sumire88
Copy link
Contributor

@sumire88 sumire88 commented Apr 2, 2024

Background

As the title suggests. Propose generating auth on the fly with GitHub Application. This solution may also mitigate the risk of hitting GitHub API rate limit.

Checklist

Full Changelogs

  • ci(generate-changelogs.yml): generate auth token on the fly

Issue Reference

NA

Test Result

https://github.com/daeuniverse/dae/actions/runs/8521439334/job/23339571820

image

Copy link
Contributor

@dae-prow dae-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Since the PR has been fully tested, please consider merging it.

@sumire88 sumire88 merged commit 8f79d3b into main Apr 2, 2024
4 checks passed
@sumire88 sumire88 deleted the ci/app-auth-token branch April 2, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants