Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shoot ipv6 icmp redirects #494

Merged
merged 2 commits into from
Apr 8, 2024
Merged

fix: shoot ipv6 icmp redirects #494

merged 2 commits into from
Apr 8, 2024

Conversation

mzz2017
Copy link
Contributor

@mzz2017 mzz2017 commented Apr 7, 2024

Background

In the commits of v0.5-v0.6, lan_egress was removed, resulting in icmpv6 redirect packets not being dropped, which forces some users (旁路由用户) to use MASQUERADE.

This PR fixed it.

Checklist

Full Changelogs

  • [Implement ...]

Issue Reference

Closes #[issue number]

Test Result

@mzz2017 mzz2017 requested a review from a team as a code owner April 7, 2024 14:03
@mzz2017 mzz2017 changed the title fix: shot ipv6 icmp redirects fix: shoot ipv6 icmp redirects Apr 7, 2024
jschwinger233
jschwinger233 previously approved these changes Apr 7, 2024
Copy link
Member

@jschwinger233 jschwinger233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint failures. Others look good.

Copy link
Contributor

@dae-prow dae-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Since the PR has been fully tested, please consider merging it.

@mzz2017 mzz2017 merged commit 7defd23 into main Apr 8, 2024
31 checks passed
@mzz2017 mzz2017 deleted the mzz/disable_ipv6_redirects branch April 8, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants