Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cannot use must in bracket in fallback #495

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

mzz2017
Copy link
Contributor

@mzz2017 mzz2017 commented Apr 8, 2024

Background

image
routing {
  # ...
  fallback: direct(must) # panic case
  fallback: must_direct # normal case
}

The above two cases should be equivalent, but one of them panics by mistake. This PR fixes this problem.

Checklist

Full Changelogs

  • [Implement ...]

Issue Reference

Closes #[issue number]

Test Result

@mzz2017 mzz2017 requested a review from a team as a code owner April 8, 2024 11:57
Copy link
Contributor

@dae-prow dae-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Since the PR has been fully tested, please consider merging it.

@mzz2017 mzz2017 merged commit c1a7a64 into main Apr 8, 2024
29 checks passed
@mzz2017 mzz2017 deleted the mzz/fix_fallback_must_in_bracket branch April 8, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants