Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use go mod cache instead of go mod vendor #42

Merged
merged 20 commits into from Jun 17, 2023
Merged

Conversation

mzz2017
Copy link
Contributor

@mzz2017 mzz2017 commented Jun 17, 2023

Background

Use go mod cache for fuller mod support.

Checklist

@mzz2017 mzz2017 requested a review from a team as a code owner June 17, 2023 05:08
@mzz2017 mzz2017 marked this pull request as draft June 17, 2023 05:09
@mzz2017 mzz2017 marked this pull request as ready for review June 17, 2023 05:33
kunish
kunish previously approved these changes Jun 17, 2023
Copy link
Member

@kunish kunish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@mzz2017 mzz2017 marked this pull request as draft June 17, 2023 05:49
@mzz2017
Copy link
Contributor Author

mzz2017 commented Jun 17, 2023

Tested and not passed.

git submodule update --init --recursive -- wing && \
touch wing
fatal: not a git repository (or any of the parent directories): .git

@mzz2017 mzz2017 marked this pull request as ready for review June 17, 2023 08:31
@mzz2017
Copy link
Contributor Author

mzz2017 commented Jun 17, 2023

Partially conflicted with #40.

@miooochi
Copy link
Contributor

miooochi commented Jun 17, 2023

We also need to sync the same proposed changes for build-nightly.yml. It might look a bit dummy for now because redundant code blocks are everywhere... Let's just leave it as it is for now. We will be working on improvement in the up-coming PRs. cc @kunish

@st0nie
Copy link

st0nie commented Jun 17, 2023

The gentoo packaging environment requires a network sandbox, so the make process cannot be networked, using vendor may cause compilation errors when trying to download packages (because of the network sandbox), using go mod cache can ensure that all the dependent packages are local, so that the package can be packaged properly

@miooochi miooochi linked an issue Jun 17, 2023 that may be closed by this pull request
@mzz2017 mzz2017 marked this pull request as draft June 17, 2023 15:25
@mzz2017
Copy link
Contributor Author

mzz2017 commented Jun 17, 2023

I have converted this PR to a draft because there is a bug that no mips files in action artifacts.

@miooochi
Copy link
Contributor

miooochi commented Jun 17, 2023

I have converted this PR to a draft because there is a bug that no mips files in action artifacts.

We got to merge it ASAP. Is it hard to fix?

@mzz2017
Copy link
Contributor Author

mzz2017 commented Jun 17, 2023

We got to merge it ASAP. Is it hard to fix?

No. I just want to remind you that it is not ready to review and merge yet due to some problems.

@mzz2017 mzz2017 marked this pull request as ready for review June 17, 2023 16:06
@mzz2017 mzz2017 merged commit fc206d3 into main Jun 17, 2023
9 checks passed
@mzz2017 mzz2017 deleted the fix_go_mod_cache branch June 17, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Support Request] Gentoo packaging dependencies issue
4 participants