-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use go mod cache instead of go mod vendor #42
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Tested and not passed.
|
Partially conflicted with #40. |
We also need to sync the same proposed changes for |
The gentoo packaging environment requires a network sandbox, so the make process cannot be networked, using vendor may cause compilation errors when trying to download packages (because of the network sandbox), using go mod cache can ensure that all the dependent packages are local, so that the package can be packaged properly |
I have converted this PR to a draft because there is a bug that no |
We got to merge it ASAP. Is it hard to fix? |
No. I just want to remind you that it is not ready to review and merge yet due to some problems. |
Background
Use
go mod cache
for fuller mod support.Checklist