-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add configure hysteria2 modal #440
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your hard work! This is truly impressive.
src/utils/node.ts
Outdated
port: number | ||
params: Record<string, string | number | boolean> | ||
}) => { | ||
const uri = new URL(`${protocol}://${auth}@${host}:${port}/`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In some cases, the auth field contains the character @
. We should consider implementing an escape mechanism.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your professional advice, fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have an issue where my hysteria2 server cannot connect properly if the password contains @, regardless of whether the client escapes it or not. I'm not sure if it's a problem with the implementation on the dae side or if the hysteria2 server's password settings themselves don't support @
server eg:
auth:
type: password
password: '@99888'
pinSHA256: values.pinSHA256, | ||
} | ||
|
||
return onLinkGeneration( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the dependency chain daed -> wing -> dae
by git submodule, we must wait for updates before the backend can function. Perhaps we should mark this PR as a draft, considering that CI builds lack actual backend implementation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Background
Ref: https://v2.hysteria.network/docs/developers/URI-Scheme/
Checklist
Full Changelogs
Issue Reference
Closes #[issue number]
Test Result