Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config): show interface ip addresses in interface select #72

Merged
merged 1 commit into from Jun 19, 2023
Merged

feat(config): show interface ip addresses in interface select #72

merged 1 commit into from Jun 19, 2023

Conversation

kunish
Copy link
Member

@kunish kunish commented Jun 19, 2023 •
edited

Background

This PR adds a feature, show interface ip addresses in interface field select component

Here's a preview about this feature

image

Checklist

Full changelog

  • feat(config): show interface ip addresses in interface select

Issue reference

None

@kunish kunish requested a review from a team as a code owner June 19, 2023 06:53
@dae-prow dae-prow bot added the feature label Jun 19, 2023
@kunish kunish requested a review from a team June 19, 2023 06:53
@mzz2017
Copy link
Contributor

mzz2017 commented Jun 19, 2023

This feature is fantastic~

@kunish kunish merged commit 8279137 into main Jun 19, 2023
15 checks passed
@kunish kunish deleted the config-form-show-interface-ip-addrs branch June 19, 2023 06:59
@kunish
Copy link
Member Author

kunish commented Jun 19, 2023

This feature is fantastic~

Thanks bro :)

This was referenced Jun 20, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@miooochi miooochi mentioned this pull request Jun 21, 2023
Closed
@github-actions github-actions bot mentioned this pull request Jun 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzz2017 mzz2017 mzz2017 approved these changes

Assignees

@kunish kunish

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kunish @mzz2017