Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add sync-upstream workflow #76

Merged
merged 1 commit into from Jun 19, 2023
Merged

ci: add sync-upstream workflow #76

merged 1 commit into from Jun 19, 2023

Conversation

miooochi
Copy link
Contributor

@miooochi miooochi commented Jun 19, 2023

Background

Add sync-upstream workflow back, but this time, let's do NOT add the broken PR create action. Instead, let @daebot automate the PR creation for us.

Checklist

Full changelog

  • ci: add sync-upstream workflow

Mock

Try to reproduce the test scenario as much as I could...

Expected Outcome

  • The sync-upstream workflow in daed-1 is kicked off
  • daebot creates a pull_request after the workflow run has been completed

Reproduction

1.1 checkout to a specific history commit in dae-wing submodule

image image image

1.2 kick off the sync-upstream workflow by pushing a commit to ci-bot-experiment origin/main

Note: In the production case, we should use dae-wing.

image

1.3 create a PR on the fly

image image image

Issue reference

NA

@miooochi miooochi requested a review from a team as a code owner June 19, 2023 13:27
@dae-prow dae-prow bot added the ci label Jun 19, 2023
@kunish
Copy link
Member

kunish commented Jun 19, 2023

Sounds really great. But we need more evidence showing this would work as expected before merging.

@miooochi
Copy link
Contributor Author

Sounds really great. But we need more evidence showing this is working as expected before merging.

Sure, let me work on the bot automation part.

@miooochi
Copy link
Contributor Author

miooochi commented Jun 19, 2023

Result: daeuniverse#1

image

Copy link
Member

@kunish kunish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants