Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can Compile output didn't work properly with CanJS 2.1 #22

Closed
tracer99 opened this issue May 28, 2014 · 1 comment
Closed

Can Compile output didn't work properly with CanJS 2.1 #22

tracer99 opened this issue May 28, 2014 · 1 comment

Comments

@tracer99
Copy link

Two issues. One was easy, the compiled template file calls can.view.preload, but should call can.view.preloadStringRenderer.

The other I'm not clear on. In can.ejs from 2.1.1 there is the following lines:
viewData.templateType = "legacy";
if (viewData.tagName) {
viewCallbacks.tagHandler(el, viewData.tagName, viewData);
}

For certain templates, viewData was undefined. Wrapping these lines with a test for the presence of viewData seems to have fixed things. Tests show the templates that were causing the problem rendered correctly. Stopped trying to figure out why this was happening.

@daffl
Copy link
Contributor

daffl commented Jun 10, 2014

Closed via #23

@daffl daffl closed this as completed Jun 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants