Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version and wrapper-options are not working with grunt #8

Closed
wants to merge 1 commit into from

Conversation

daniel-franz
Copy link

...as those options are supposed to be in options.options

options is:

{
    src: '*.mustache',
    out: 'filename.js',
    options: {
        version: '2.0.0-pre'
    }
}

...as those options are supposed to be in options.options

options is:

    {
        src: '*.mustache',
        out: 'filename.js',
        options: {
            version: '2.0.0-pre'
        }
    }
@daffl
Copy link
Contributor

daffl commented Oct 16, 2013

The docs were wrong, it is actually supposed to be

{
    src: '*.mustache',
    out: 'filename.js',
    version: '2.0.0-pre'
}

I changed it in the documentation but in the next version this should indeed move into options though.
Would like to fix #5 for that as well as we are getting close to a DOM-less compilation.

@daniel-franz
Copy link
Author

A docu-fix is ok, too. Thanks a lot.

@daffl
Copy link
Contributor

daffl commented Oct 17, 2013

Lets keep this PR open so that I don't forget to change the Grunt task options when we have the DOM-less compilation.

@daffl daffl closed this in fb4318c Jun 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants