fix: thread-safety issue in the runtime #1780
Conversation
fabiomadge
force-pushed
the
fix_gh_1454
branch
from
19fe6c4
to
4ced96c
Compare
| } | ||
|
|
||
| [Fact(Timeout = 5000)] | ||
| public void RunCoyoteTest() { |
There was a problem hiding this comment.
I'm happy to say I'm able to run this test locally myself (after doing a dotnet tool restore), but it passes even if I revert your fix below. I CAN reproduce the problem by only commenting out all but two tasks and setting a breakpoint on the elmts = ComputeElements(); line of the ImmutableElements getter and then debugging the ConcatSequence test directly through Rider: having two threads ready to go on that line pretty consistently leads to NullReferenceExceptions once I resume execution.
My hope was that Coyote would be able to definitively reproduce the bug first, since it's deterministically testing many thread interleavings. We should either find a simple enough Coyote test that reveals the bug, or not bother with Coyote at all.
robin-aws
dismissed
their stale review
Not confident enough to approve, but don't want to block while away
Fixes #1454